chore(cubesql): Remove usage of nightly features #9215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
changed the title
ovr
force-pushed
the
feat/unblock-rust-stable
branch
2 times, most recently
from
ed7f31a to
80be6a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9215 +/- ##
==========================================
- Coverage 83.44% 83.44% -0.01%
==========================================
Files 227 227
Lines 81599 81626 +27
==========================================
+ Hits 68094 68113 +19
- Misses 13505 13513 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ovr
force-pushed
the
feat/unblock-rust-stable
branch
from
57b28ba to
535bb19
Compare
MazterQyou
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks an ability to upgrade rust to stable 1.84.1. I am going to do the rust upgrade in the separate PR - #9222
Usage of
thiserrorcrate was removed for two error structures (ProtocolErrorfrompg-srvandCompilationErrorfromcubesql), because using Backtrace in errors requires a nightly compiler with Rust version 1.73 or newer. Move it to manual implementation